ThymeleafAutoConfiguration fails if thymeleaf-spring5 is not present #16341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an extra check for the presence of thymeleaf-spring5 library on the classpath. Since now ThymeleafAutoConfiguration is considered only if both thymeleaf-spring5 and thymeleaf jars are present. spring-projectsgh-16079
spring-projects-issues
added
the
status: waiting-for-triage
|
The current code base from master does not build. You can spot this build failure in the latest builds:
I was able to reproduce it locally with the following configuration: JVM/Maven: Git revision Let me know if it's a known case or if I should raise an issue for it. |
|
Thank you. As you’ve seen yourself CI has been failing, probably due to a change in a snapshot dependency. We are aware of it and will work on a fix. |
4 tasks
snicoll
added
type: bug
snicoll
approved these changes
Mar 28, 2019
snicoll
added a commit
that referenced
this pull request
Mar 28, 2019
* pr/16341: Add missing class condition on thymeleaf-spring5
|
@koziolk thank you for making your first contribution to Spring Boot. Your work has been merged in |
snicoll
added a commit
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an extra check for the presence of thymeleaf-spring5
library on the classpath. Since now ThymeleafAutoConfiguration is
considered only if both thymeleaf-spring5 and thymeleaf jars are present.
gh-16079