Skip to content

Conversation

yalov4uk
Copy link

Currently in the project spring-boot-actuator-autoconfigure 2.1.3 there is no way to declaratively disable logfile endpoint if logging.file property exists.
So this PR is created to logfile actuator behave as other actuators.
And while i was fixing tests I had noticed that the test's method name was "logFileWebEndpointCanBeDisabled" whereas it tests bean creation.

@pivotal-issuemaster
Copy link

@yalov4uk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@yalov4uk Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 23, 2019
@snicoll
Copy link
Member

snicoll commented Mar 25, 2019

@yalov4uk good catch, looks like the base condition was missed since day one!

@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 25, 2019
@snicoll snicoll self-assigned this Mar 25, 2019
@snicoll

This comment has been minimized.

@snicoll snicoll changed the title Add possibility to disable logfile actuator, fix tests Logfile endpoint cannot be disabled using the standard property Mar 25, 2019
snicoll added a commit that referenced this pull request Mar 25, 2019
@snicoll snicoll added this to the 2.1.4 milestone Mar 25, 2019
@snicoll snicoll closed this in c880e10 Mar 25, 2019
snicoll added a commit that referenced this pull request Mar 25, 2019
* pr/16298:
  Fix LogFile conditions to check for exposure as well
@snicoll
Copy link
Member

snicoll commented Mar 25, 2019

@yalov4uk thank you very much for your first contribution to Spring Boot. I've backported a fix to 2.1.x and merged your contribution to master.

@snicoll
Copy link
Member

snicoll commented Mar 25, 2019

Actually the tests are not working anymore and I forgot to re-run them when looking at master

@snicoll snicoll reopened this Mar 25, 2019
@yalov4uk
Copy link
Author

From the logs i cannot determine the problem.

@snicoll snicoll closed this in b055410 Mar 25, 2019
@snicoll
Copy link
Member

snicoll commented Mar 25, 2019

From the logs i cannot determine the problem.

@yalov4uk you don't need to wait for CI to figure out the problem. Building the module or running that test from your IDE should have shown you the test failures.

@yalov4uk

This comment has been minimized.

@snicoll

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants