Trim trailing whitespace from value of spring.server.servlet.context-path #16165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Mar 12, 2019
snicoll
added a commit
that referenced
this pull request
Mar 12, 2019
* pr/16165: Polish "Trim trailing whitespace from spring.server.servlet.context-path" Trim trailing whitespace from spring.server.servlet.context-path
|
@mrifni thank you very much for making your first contribution to Spring Boot. This is now merged in |
|
@snicoll you welcome! happy to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fix for issue #15972.
I have added few unit tests to make sure the changes works.
Describing the problem:
Servlet context path specified in the application.properties file doesnt remove leading or trailing spaces and and it may result in 404 errors.