Update instructions on how to use JAXB as XML renderer #16005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snicoll
reviewed
Feb 20, 2019
| ---- | ||
|
|
||
| If Jackson's XML extension is not available, JAXB (provided by default in the JDK) is | ||
| If Jackson's XML extension is not available, JAXB (provided by default in the JDK 8) is |
There was a problem hiding this comment.
Rather than focusing on JDK 8 and now that this is an optional feature, I'd prefer if we rephrase that section along the lines of "if available".
|
Should I rebase the PR against 2.1.x or will the change be cherry-picked into 2.1.x ? |
|
Don't worry about that we can take care of it |
|
@larsgrefer I did requested a change though, are you willing to update the PR? |
snicoll
added
the
status: waiting-for-feedback
Update instructions on how to use JAXB as XML renderer.
|
@snicoll I've restructured the section and added more general instructions on how to use JAXB. |
snicoll
removed
the
status: waiting-for-feedback
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Feb 26, 2019
snicoll
added a commit
that referenced
this pull request
Feb 26, 2019
* pr/16005: Polish "Update instructions on how to use JAXB as XML renderer" Update instructions on how to use JAXB as XML renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.