Fat jar built with Maven does not repackage META-INF/<module-name>.kotlin_module files into BOOT-INF/classes #16004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Feb 20, 2019
wilkinsona
added a commit
that referenced
this pull request
Feb 20, 2019
|
Thanks very much for the PR, @thorntonrp. I've merged the proposed changes into 2.1.x and forwards into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #16003 and adds a maven invoker test to verify that the fix works when there is a kotlin_module in the project.