Skip to content

Add HANA to the lookup of well-known databases #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add HANA to the lookup of well-known databases #15125

wants to merge 1 commit into from

Conversation

breglerj
Copy link
Contributor

@breglerj breglerj commented Nov 7, 2018

HANA has been added to the DatabaseDriver enum with PR #14513, but it is still missing in the DatabaseLookup utility class.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 7, 2018
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 7, 2018
@philwebb philwebb added this to the 2.1.x milestone Nov 7, 2018
@snicoll snicoll changed the title Add HANA to the lookup of well-known databases. Add HANA to the lookup of well-known databases Nov 10, 2018
@snicoll snicoll added type: enhancement A general enhancement and removed type: bug A general bug labels Nov 10, 2018
@snicoll snicoll self-assigned this Nov 10, 2018
@snicoll snicoll modified the milestones: 2.1.x, 2.1.1 Nov 10, 2018
snicoll pushed a commit that referenced this pull request Nov 10, 2018
@breglerj @snicoll
Add HANA to the lookup of well-known databases
85754ea 
See gh-15125
@snicoll snicoll closed this in 089ef90 Nov 10, 2018
snicoll added a commit that referenced this pull request Nov 10, 2018
@snicoll
Merge pull request #15125 from breglerj
575070a 
* pr/15125:
  Polish "Add HANA to the lookup of well-known databases"
  Add HANA to the lookup of well-known databases
@snicoll
Copy link
Member

snicoll commented Nov 10, 2018

Good catch, HANA was added in Spring Framework 5.1 and we forgot to update our mapping here. I've merged this one with a polish commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@breglerj @snicoll @philwebb @spring-projects-issues