Custom error.jsp page is not used when app is run as anything other than a packaged war #12859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralenmdp Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ralenmdp Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR but I don't think this is the right way to fix the problem. I've not keen for |
philwebb
added
status: declined
|
On reflection, we can't think of a better way to do this. The embedded containers already have knowledge or |
wilkinsona
added
type: bug
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Jun 21, 2018
wilkinsona
added a commit
that referenced
this pull request
Jun 21, 2018
* gh-12859: Polish "Fix JSP availability check when not running as a packaged war" Fix JSP availability check when not running as a packaged war
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12805
Try to look for the webapps folder so that WhitelabelErrorViewConfiguration will not create another error bean view and let InternalResourceViewResolver resolve the error page in embedded container.