HowTo 'Enable HTTPS when running behind a proxy server' uses incorrect properties #10256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties server.tomcat.remote-ip-header and server.tomcat.protocol-header were misspelled, using an underline instead of an dash.
|
@aconstantin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@aconstantin Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks! |
snicoll
added a commit
that referenced
this pull request
Sep 11, 2017
* pr/10256: Use underline instead of dash in tomcat properties
Member
|
@aconstantin Thank you for making your first contribution to Spring Boot. This is now merged in |
snicoll
added
type: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to the documentation and the code, the properties used in the Enable HTTPS when running behind a proxy server HowTo are with underline instead of dashes.
server.tomcat.remote_ip_header instead of server.tomcat.remote-ip-header
server.tomcat.protocol_header instead of server.tomcat.protocol-header