Skip to content

TestRestTemplate.withBasicAuth(...) does not remove BasicAuthInterceptor if present #7812

@PeterSt66

Description

@PeterSt66

Following code in TestRestTemplate (starting at line 999) does not remove BasicAuthorizationInterceptor's from result, return value of the method should be updatedInterceptors instead of interceptors.

private List<ClientHttpRequestInterceptor> removeBasicAuthInterceptorIfPresent( 
			List<ClientHttpRequestInterceptor> interceptors) { 
		List<ClientHttpRequestInterceptor> updatedInterceptors = new ArrayList<ClientHttpRequestInterceptor>( 
 				interceptors); 
 		Iterator<ClientHttpRequestInterceptor> iterator = updatedInterceptors.iterator(); 
 		while (iterator.hasNext()) { 
 			if (iterator.next() instanceof BasicAuthorizationInterceptor) { 
 				iterator.remove(); 
 			} 
 		} 
 		return interceptors; 
 	} 

Link to Github:
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-test/src/main/java/org/springframework/boot/test/web/client/TestRestTemplate.java#L1009

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions