Make @ConditionalOnBean with multiple beans an AND rather than an OR

[wilkinsona]

[philwebb]

Probably a 2.0 change and one that I'm not too keen on since it could break code in a very subtle way.

[wilkinsona]

I thought you'd say that :)

[derTobsch]

I would be nice if we get a AND with 2.0. :-) I have the case that I want to expose a bean, when two other beans are on the bean factory. Now I got a workaround with one @ConditionalOnBean annotation on the method and one at class level.

Could it be an idea to provide an annotation attribute to switch between "or" and "and" and the default would still be "or" so nothing would break?

[philwebb]

@derTobsch Have you seen the AllNestedConditions, AnyNestedCondition and NoneNestedConditions classes? You can use those to combine conditions together.

[derTobsch]

@philwebb that's a good reminder. I knew them but barely use them. I give them a try, that should work just fine. thanks

[derTobsch]

I tried it and it does work but it feels a little bit cumbersome :-)

Here the code for other users finding this issue. I want that both beans are already in the bean factory before running this auto configuration. So i created a inner class and added @Conditional(ConditionOnSecurityAndDiscovery.class) on my auto configuration class.

    static class ConditionOnSecurityAndDiscovery extends AllNestedConditions {

        ConditionOnSecurityAndDiscovery() {

            super(ConfigurationPhase.REGISTER_BEAN);
        }

        @ConditionalOnBean(CoffeeNetAppService.class)
        static class OnDiscovery {
        }

        @ConditionalOnBean(CoffeeNetCurrentUserService.class)
        static class OnSecurity {
        }
    }

examples here e.g. https://github.com/spring-projects/spring-boot/blob/8470ecb4d05c2bcaadd9c58cc7564d7687ae02cd/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/hazelcast/HazelcastJpaDependencyAutoConfiguration.java

I must say, that I would prefer something like this below in in the 2.0 version

@ConditionalOnBean(classes = {CoffeeNetAppService.class, CoffeeNetCurrentUserService.class}, operation = Operation.AND)

Thanks for your help @philwebb