MockMvc logging requests from all previous tests with Spring Boot Test

[OrangeDog]

I'm sure this didn't use to happen, but I only just noticed while using 5.1.8.RELEASE.
With the default @AutoConfigureMockMvc settings, on a test failure it logs not only the requests from the failing tests, but also all previous passing tests.

Some brief testing shows this goes back to at least 5.1.0.RELEASE.

[sbrannen]

@philwebb and @wilkinsona, this sounds like a Spring Boot issue to me.

Could it be that DeferredLinesWriter doesn't get reset between tests that use the same ApplicationContext?

[wilkinsona]

That certainly looks like it could be the case. @OrangeDog can you share something that reproduces the behaviour you're seeing please?

[OrangeDog]

@WebMvcTest
@RunWith(SpringRunner.class)
public class TestClass {
    @Autowired
    private MockMvc mockMvc;

    @Test
    public void one() throws Exception {
        mockMvc.perform(get("/one")).andExpect(status().isNotFound());
    }

    @Test
    public void two() throws Exception {
        mockMvc.perform(get("/two")).andExpect(status().isOk());
    }
}

<parent>
  <groupId>org.springframework.boot</groupId>
  <artifactId>spring-boot-starter-parent</artifactId>
  <version>2.1.0.RELEASE</version>
</parent>

<dependencies>
  <dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-web</artifactId>
  </dependency>
  <dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-test</artifactId>
  </dependency>
</dependencies>

I checked 2.0.9.RELEASE as well, and it has the same problem.

[wilkinsona]

Thanks, @OrangeDog. As suspected, this is a bug in Boot. We'll move the issue over and fix it there.