Exclude correct HikariCP version

[pse-sonic]

Hello,

Spring Boot 2.1.4-RELEASE uses Quartz 2.3.1 which contains hikaricp-java7 (since this release - see quartz-scheduler/quartz#294) but the spring-boot-dependencies POM still excludes hikaricp-java6.

This causes an AbstractMethodError when using HikariCP and Quartz together.

Caused by: java.lang.AbstractMethodError: Receiver class com.zaxxer.hikari.metrics.micrometer.MicrometerMetricsTrackerFactory does not define or inherit an implementation of the resolved method abstract create(Ljava/lang/String;Lcom/zaxxer/hikari/metrics/PoolStats;)Lcom/zaxxer/hikari/metrics/MetricsTracker; of interface com.zaxxer.hikari.metrics.MetricsTrackerFactory.

Best regards
Sebastian

[ielatif]

Is this open for contribution? I would be happy to contribute if @pse-sonic don't mind

[pse-sonic]

Feel free to solve this issue :)

[snicoll]

@ielatif fixing the issue is easy but I'd like to put something in place so that our build fails the next time this happens. If you want to give that a try, feel free to go ahead.

[ielatif]

This is similar to this one #12364

There is tests for Quartz in QuartzAutoConfigurationTests. We can add a new test withHikariCPDataSource to integrate HikariCP and Quartz. @snicoll What do you think?

[snicoll]

@ielatif it's already using HikariCP most probably. If you managed to reproduce the error in a test, feel free to submit something.

[thackel]

Additionally the project should really set up a duplicate classpath check for a maximum possible amount of dependencies (all starters for example).
This would avoid such kind of issues in the future.

[peterssond]

Is there a workaround for this issue, or should I stay on 2.1.3?

[snicoll]

You can exclude the dependency yourself in your project for the time being.

[ielatif]

PR #16502

[snicoll]

Closing in favour of PR #16502