Repackage goal does not lazily resolve "project.build.finalName" anymore

[marcust]

I'm using git-commit-id-plugin to build my final name on <build> level like

<finalName>${project.name}-${version.number}</finalName>

and version.number is defined as

<version.number>${git.commit.time}-${git.commit.id.describe-short}</version.number>

That used to work up to now, but 2.1.4 does not evaluate these variables anymore, so I get

project-${git.commit.time}-${git.commit.id.describe-short}.jar
project-20190404-115039-0bfd654.jar

in my target directory, where the one with the unevaluated variables is the actuall repackaged jar.
I tried now half an hour to achieve the same thing any other way and didn't find a solution, I guess that has something to do with #16202. Can we get the old behaviour back?

[snicoll]

It is hard to understand what you’re trying to describe with partial config snippet. Can you share a sample that reproduces what you’re describing?

[snicoll]

Small note, if you're using the finalName property of the plugin, it's deprecated since 2.1.0 in favour of the standard finalName of the build element. If you're using the former, this was working by accident (see also #16457 for more insight).

[marcust]

Demo is at https://github.com/marcust/spring-boot-issue-16456

So when you do a
mvn clean package
right now, you get in target/

demo-${git.commit.time}-${git.commit.id.describe-short}.jar
demo-20190404-181706-307869c.jar

if you do that with Spring Boot 2.1.3. you get

demo-20190404-181706-307869c-dirty.jar
demo-20190404-181706-307869c-dirty.jar.original

so basically the behaviour of the standard fileName element has changed.

[snicoll]

Alright so my attempt at stopping users from specifying a read-only parameter was a bit too agressive. The fact that read-only is completely ignored by Maven is a confirmed bug so we need to find a way to fix #16202.

A revert of 04aadcd will reintroduce the issue so it would be nice if we could detect it and throw an exception instead.

There is also some insight in git-commit-id/git-commit-id-maven-plugin#256