Cannot run repackage twice with different settings

[wouterv]

Since the release of 2.1.0.RELEASE, we get the following issue in our build:

build	31-Oct-2018 15:08:38	[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.1.0.RELEASE:repackage (build-repackaged-jar) on project application: Execution build-repackaged-jar of goal org.springframework.boot:spring-boot-maven-plugin:2.1.0.RELEASE:repackage failed: Source must refer to an existing file, got /atlassian/bamboo/agent/5.15.3/xml-data/build-dir/BC-BGS-JOB1/repo/application/target/gear-exec-linux.jar.original -> [Help 1]

We fixed the plugin version to 2.0.6.RELEASE and all works fine again.

This is our specific part in the pom, the special thing about is that it creates two artifacts:

 <plugin>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-maven-plugin</artifactId>
    <version>2.0.6.RELEASE</version> <!-- remove this and it will fail -->
    <executions>
        <execution>
            <id>build-linux-executable</id>
            <goals>
                <goal>repackage</goal>
            </goals>
            <configuration>
                <classifier>exec-linux</classifier>
                <executable>true</executable>
                <attach>false</attach>
            </configuration>
        </execution>    
        <execution>
            <id>build-repackaged-jar</id>
            <goals>
                <goal>repackage</goal>
            </goals>
            <configuration>
                <executable>false</executable>
                <attach>true</attach>
            </configuration>
        </execution>
    </executions>
</plugin>

[wilkinsona]

Thanks for the pom snippet, but I've been unable to reproduce the problem with it. As far as I can tell, the Maven plugins from 2.0.6 and 2.1.0 behave in the same way with that configuration. I have been testing with Maven 3.5.4. If you'd like us to spend some more time on this, can you please spend the time to produce a complete, minimal example that reproduces the behaviour you have described.

[snicoll]

@wouterv I am not 100% sure but this looks related to #14210 . Can you please double check? I've also updated the release notes to mention the new repackage execution id.

[wouterv]

@snicoll I tried with the execution id specific for the "main" artifact (the one without the classifier), but that did not help.

What did help however is changing the order to the following and now it works:

            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
                <executions>
                    <execution>
                        <id>build-repackage-executable</id>
                        <goals>
                            <goal>repackage</goal>
                        </goals>
                        <configuration>
                            <executable>false</executable>
                            <attach>true</attach>
                        </configuration>
                    </execution>
                    <execution>
                        <id>build-linux-executable</id>
                        <goals>
                            <goal>repackage</goal>
                        </goals>
                        <configuration>
                            <classifier>exec-linux</classifier>
                            <executable>true</executable>
                            <attach>false</attach>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

I'll leave the qualification of this to be a bug or a feature up to you ;-)

[snicoll]

@wouterv can you please attach a small sample that reproduces the problem? We can't really qualify something we can't reproduce. Thanks

[wouterv]

Sorry, it wasn't fixed by the thing I posted, but I created a sample demo by which you can test the change of behavior by just changing the plugin version.
demo.zip