MessageSource not working after 1.1.5 upgrade

[mbyrne00]

Using spring-boot 1.1.4, the default MessageSource bean I get is a ResourceBundleMessageSource instance loading from my messages.properties on the root classpath.

When I upgraded to 1.1.5 the default MessageSource bean I get is now a DelegatingMessageSource with no parentMessageSource, so no messages are resolved. I still have messages.properties on the root classpath.

Was a breaking change so I needed to roll back to 1.1.4

[philwebb]

The @Condition logic on MessageSourceAutoConfiguration changed with 0def764. My guess is that this change is preventing the auto-configured bean from being registered. Have you got a spring.messages.basename property set? Could you try debugging ResourceBundleCondition.getMatchOutcome and letting us know if it matches or not?

[mbyrne00]

Hi Phil - thanks for the reply. It's the end of our day so I can debug tomorrow, but in the mean time I can confirm that I have not set the spring.messages.basename property explicitly in my app.

[mbyrne00]

ResourceBundleCondition.getMatchOutcome is returning Condition.noMatch(...)

I debugged the code and I think I found the troublesome line. In MessageSourceAutoConfiguration.java, line 121 the wildcard does not seem to be working.

return new PathMatchingResourcePatternResolver(classLoader) .getResources("classpath*:" + name + "*.properties");

This returns an empty array. It calls .getResources("classpath*:messages*.properties"); and returns nothing.

When I try without the trailing wildcard (before the file extension) in my debugger then I get an array with one element.

This works (no asterix before .properties):
new PathMatchingResourcePatternResolver(classLoader) .getResources("classpath*:messages.properties");

Note that I do not have any locale-specific messages.properties, just the default single messages.properties file in the root classpath.

[philwebb]

That's an odd issue. I've been trying to replicate it locally in a test case without any luck. It seems that for me classpath*:messages*.properties returns a single item.

Is your project failing when you run from an IDE or when it is packaged as a JAR? Do you have time to create a sample project that replicates the issue?

[mbyrne00]

I'm heading home for the weekend so won't get time to create a sample project until Monday. I'm running under Java 8 and have the problem when running via mvn spring-boot:run in the web application (not through the IDE).

[mbyrne00]

Another key piece of info that might help. My project is multi-module and the messages.properties is in the services jar. The web module includes this as a dependency. I know classpath*: should resolve this but maybe it has something to do with the wildcard match.

[mbyrne00]

Sample project created with this pull request: spring-attic/spring-boot-issues#9.

To reproduce issue:
spring-boot-issues/gh-1378> mvn clean install
spring-boot-issues/gh-1378/sample-1378-web> mvn spring-boot:run

You will get an exception trying to resolve the message for sample.message. If you change the dependency on spring-boot to 1.1.4-RELEASE it will work and print a message to console on startup.

I didn't have time to see if I can get this into a unit test, but the sample project illustrates the problem with stripped-down dependencies to simplify troubleshoting.

[snicoll]

Merged and available here