Skip to content

environmentWebEndpointExtension bean name used for two different classes #12827

@JagmohanSharma

Description

@JagmohanSharma

EnvironmentEndpointAutoConfiguration has a bean with name environmentWebEndpointExtension of type EnvironmentEndpointWebExtension and LifecycleMvcEndpointAutoConfiguration also has bean with same name environmentWebEndpointExtension but of type EnvironmentWebEndpointExtension which seems right.

I think we should change the name for bean of type EnvironmentEndpointWebExtension or I am missing something here?

Below from LifecycleMvcEndpointAutoConfiguration:

@Configuration
    @ConditionalOnClass(EnvironmentEndpoint.class)
    @ConditionalOnWebApplication
    protected static class EndpointConfiguration {
        @Bean
        @ConditionalOnBean(EnvironmentEndpoint.class)
        @ConditionalOnEnabledEndpoint
        public EnvironmentWebEndpointExtension environmentWebEndpointExtension(
                EnvironmentManager environment) {
            return new EnvironmentWebEndpointExtension(environment);
        }
    }

Below from EnvironmentEndpointAutoConfiguration:

@Bean
	@ConditionalOnMissingBean
	@ConditionalOnEnabledEndpoint
	@ConditionalOnBean(EnvironmentEndpoint.class)
	public EnvironmentEndpointWebExtension environmentWebEndpointExtension(
			EnvironmentEndpoint environmentEndpoint) {
		return new EnvironmentEndpointWebExtension(environmentEndpoint);
	}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions