Add a new annotation @SpringBatchTest to simplify testing #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
changed the title
@SpringBatchTest to simplify testing
mminella
reviewed
May 30, 2018
| @Override | ||
| public void customizeContext(ConfigurableApplicationContext context, MergedContextConfiguration mergedConfig) { | ||
| ConfigurableListableBeanFactory beanFactory = context.getBeanFactory(); | ||
| Assert.isInstanceOf(BeanDefinitionRegistry.class, beanFactory); |
There was a problem hiding this comment.
Added an error message (and also added a test to cover the case).
| * @author Mahmoud Ben Hassine | ||
| * @since 4.1 | ||
| * @see JobLauncherTestUtils | ||
| * @see org.springframework.batch.test.JobRepositoryTestUtils |
There was a problem hiding this comment.
Why is this one fully qualified?
There was a problem hiding this comment.
No reason, I don't know why this went fully qualified while others are not. Fixed.
This commit adds a new annotation `@SpringBatchTest` that: * configures two beans `JobLauncherTestUtils` and `JobRepositoryTestUtils` in the test context. * imports the `StepScopeTestExecutionListener` and `JobScopeTestExecutionListener` as test execution listeners. Resolves BATCH-2718
|
Rebased and merged as 0dab67c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new annotation
@SpringBatchTestthat:configures two beans
JobLauncherTestUtilsandJobRepositoryTestUtilsin the test context.
imports the
StepScopeTestExecutionListenerandJobScopeTestExecutionListeneras test execution listeners.Resolves BATCH-2718.