Skip to content

Deprecate overrides of StepBuilderHelper#repository for removal #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Deprecate overrides of StepBuilderHelper#repository for removal #4495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...in/java/org/springframework/batch/integration/chunk/RemoteChunkingManagerStepBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,16 @@ public RemoteChunkingManagerStepBuilder<I, O> reader(ItemReader<? extends I> rea
return this;
}

/**
* Set the job repository
* @param jobRepository the repository to set
* @return this to enable fluent chaining
* @deprecated use
* {@link RemoteChunkingManagerStepBuilder#RemoteChunkingManagerStepBuilder(String, JobRepository)}
*/
@Override
@SuppressWarnings("removal")
@Deprecated(since = "5.1", forRemoval = true)
public RemoteChunkingManagerStepBuilder<I, O> repository(JobRepository jobRepository) {
super.repository(jobRepository);
return this;
Expand Down
9 changes: 9 additions & 0 deletions ...org/springframework/batch/integration/partition/RemotePartitioningManagerStepBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,16 @@ private boolean isPolling() {
return this.inputChannel == null;
}

/**
* Set the job repository
* @param jobRepository the repository to set
* @return this to enable fluent chaining
* @deprecated use
* {@link RemotePartitioningManagerStepBuilder#RemotePartitioningManagerStepBuilder(String, JobRepository)}
*/
@Override
@SuppressWarnings("removal")
@Deprecated(since = "5.1", forRemoval = true)
public RemotePartitioningManagerStepBuilder repository(JobRepository jobRepository) {
super.repository(jobRepository);
return this;
Expand Down
9 changes: 9 additions & 0 deletions .../org/springframework/batch/integration/partition/RemotePartitioningWorkerStepBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,16 @@ public RemotePartitioningWorkerStepBuilder beanFactory(BeanFactory beanFactory)
return this;
}

/**
* Set the job repository
* @param jobRepository the repository to set
* @return this to enable fluent chaining
* @deprecated use
* {@link RemotePartitioningWorkerStepBuilder#RemotePartitioningWorkerStepBuilder(String, JobRepository)}
*/
@Override
@SuppressWarnings("removal")
@Deprecated(since = "5.1", forRemoval = true)
public RemotePartitioningWorkerStepBuilder repository(JobRepository jobRepository) {
super.repository(jobRepository);
return this;
Expand Down
1 change: 0 additions & 1 deletion ...va/org/springframework/batch/integration/chunk/RemoteChunkingManagerStepBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ void testUnsupportedOperationExceptionWhenSpecifyingAnItemWriter() {
.reader(this.itemReader)
.writer(items -> {
})
.repository(this.jobRepository)
.transactionManager(this.transactionManager)
.inputChannel(this.inputChannel)
.outputChannel(this.outputChannel)
Expand Down