AMQP-806: Simple Publisher Confirms #731
Conversation
JIRA: https://jira.spring.io/browse/AMQP-806 Avoid complex infrastructure for simple use cases.
| com.rabbitmq.client.ConfirmCallback nacks); | ||
| ---- | ||
|
|
||
| NOTE: These `ConfirmCallback` objects (for acks and nacks) are the Rabbit client callbacks, not the template callback. |
There was a problem hiding this comment.
Why we really can't use there our own org.springframework.amqp.rabbit.core.RabbitTemplate.ConfirmCallback ?
It doesn't look too hard to delegate calls from the internal Rabbit client ConfirmCallback instances.
There was a problem hiding this comment.
It doesn't really fit; we don't have correlation data or a cause or a way to convey multiple.
I suppose I could subclass CorrelationData to provide the tag and multiple. WDYT?
There was a problem hiding this comment.
Ah! I see what you mean.
No, I think it's really not necessary to overhead here: since we don't have anything to wait for, therefore we don't need correlation.
So, the current solution is fine.
Will pull locally for deeper review and possible merging...
| * @param acks a confirm callback for acks. | ||
| * @param nacks a confirm callback for nacks. | ||
| * @param <T> the return type. | ||
| * @return the result of the action method. |
There was a problem hiding this comment.
We need to add this method to RabbitOperations - can you do that if you find no more problems in the review?
There was a problem hiding this comment.
Oops - too late.
There was a problem hiding this comment.
I think we can just add subsequent commit.
Not a big deal though.
Thanks for the pointer! My bad 😄
|
Merged as 3da5931 |
JIRA: https://jira.spring.io/browse/AMQP-806
Avoid complex infrastructure for simple use cases.