Skip to content

test: Add comprehensive test coverage for Ollama runtime hints registration #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

test: Add comprehensive test coverage for Ollama runtime hints registration #4014

merged 1 commit into from
Aug 6, 2025

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 6, 2025

Adds new test cases to strengthen OllamaRuntimeHintsTests:

  • Null ClassLoader handling - Ensures registration works with null ClassLoader (AOT scenario)
  • Basic validation - Verifies hints are actually registered
  • Idempotent registration - Prevents duplicate hints on multiple calls
  • Main API classes validation - Confirms core Ollama classes are registered
  • Package validation - Ensures JSON classes found from correct package
  • Hint count control - Prevents excessive registrations that impact build time
  • Nested class support - Validates Tool and other nested classes are registered

These tests catch potential native compilation failures and ensure proper AOT hint registration for Ollama integration.

@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit 109923a into spring-projects:main Aug 6, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@alxkm @scionaltera
test: Add comprehensive test coverage for Ollama runtime hints regist…
5772eba 
…ration (spring-projects#4014)

Signed-off-by: Alex Klimenko <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@alxkm @chedim
test: Add comprehensive test coverage for Ollama runtime hints regist…
89234d0 
…ration (spring-projects#4014)

Signed-off-by: Alex Klimenko <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
@alxkm @Willam2004
test: Add comprehensive test coverage for Ollama runtime hints regist…
2499309 
…ration (spring-projects#4014)

Signed-off-by: Alex Klimenko <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

1.1.0.M1

Development

Successfully merging this pull request may close these issues.

2 participants

@alxkm @sobychacko