Skip to content

Provide a way for developers to set a custom StreamFunctionCallingHelper #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sdghchj
Copy link

@sdghchj sdghchj commented Jun 19, 2025

Refer to #3602

Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Copyright Notice year in the header of all modified files from 2023-2024 to 2023-2025.

Comment on lines +1 to +3
package org.springframework.ai.chat.model;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Copyright Notice at the beginning of the file.

Comment on lines 85 to +86
String betaPrefixPath, RestClient.Builder restClientBuilder, WebClient.Builder webClientBuilder,
ResponseErrorHandler responseErrorHandler) {
ResponseErrorHandler responseErrorHandler, StreamFunctionCallingHelper<ChatCompletionChunk> chunkMerger) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this new parameter to the method documentation.

sdghchj added 2 commits June 19, 2025 20:03
Signed-off-by: sdghchj <[email protected]>
@sdghchj
Copy link
Author

sdghchj commented Jun 19, 2025

@sunyuhan1998 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants