Skip to content

Oracle: add OracleChatMemory support #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fanxt0218
Copy link

add the support for oracle

@ilayaperumalg
Copy link
Member

@fanxt0218 Thanks for the PR! Could you add the schema and the corresponding integration test?

@fanxt0218
Copy link
Author

感谢 PR!您能否添加架构和相应的集成测试?

Ok, I've added oracle's schema and integration test classes and made it a new commit. Please review
In my environment, it passed all the test cases

@fanxt0218
Copy link
Author

In another PR #3590 , a new scaling method was implemented for all databases. However, this scaling method is not implemented in Oracle Database, so it can be problematic when merging. To keep their behavior consistent, I'm going to request another commit to fix this. Make sure they are fully compatible when they merge in the future

@fanxt0218
Copy link
Author

In another PR #3590 , a new scaling method was implemented for all databases. However, this scaling method is not implemented in Oracle Database, so it can be problematic when merging. To keep their behavior consistent, I'm going to request another commit to fix this. Make sure they are fully compatible when they merge in the future

This PR is merged after another PR is merged, and the method comment is undone
this PR Depends on #3590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants