Fix bug of service instance refetching when repeating health check is activated #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes gh-899. |
There was a problem hiding this comment.
@rchigvintsev Thanks for submitting the PR. This, in fact, fixes the issue. However, since the issue is present in Hoxton release train as well, could you please submit it against the 2.2.x branch instead of master so that the change is included in both release trains. Also, please add your full name with @author tag to the javadocs in the classes you've modified.
OlgaMaciaszek
requested changes
Feb 15, 2021
|
@OlgaMaciaszek I've just created a new PR against 2.2.x branch. |
|
@rchigvintsev Thanks :) |
|
Closing in favour of gh-904. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-899
I'm not sure it is a proper solution to this issue but it works.