Skip to content

Add each PropertySource from PropertySourceLocators individually #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2019
Merged

Add each PropertySource from PropertySourceLocators individually #652

merged 2 commits into from
Dec 13, 2019

Conversation

ryanjbaxter
Copy link
Contributor

Fixes #611

spencergibb
spencergibb approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, but otherwise LGTM. @dsyer?

@dsyer
Copy link
Contributor

dsyer commented Dec 13, 2019

LGTM

@ryanjbaxter ryanjbaxter merged commit 763b6c1 into spring-cloud:2.1.x Dec 13, 2019
@spencergibb spencergibb mentioned this pull request Dec 17, 2019
Merged
@ryanjbaxter ryanjbaxter mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencergibb spencergibb spencergibb approved these changes

+1 more reviewer

@dsyer dsyer dsyer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryanjbaxter @dsyer @spencergibb @spring-projects-issues