Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Conversation

@barni
Copy link

@barni barni commented Apr 27, 2012

Should be same error as in SPR-9181

cbeams added a commit that referenced this pull request May 1, 2012
* SPR-9181:
  Add repro project for SPR-9181
@cbeams
Copy link
Contributor

cbeams commented May 1, 2012

Thanks. This repro project has been merged into master, but after a number of modifications:

  • squashed into a single atomic commit
  • converted tabs to spaces
  • updated your git author name, which was previously unknown

For any future contributions, please submit the pull request from a branch with the same name as the JIRA issue ID. This pull request was submitted from your fork's master branch, and that's not as clean to work with when merging things in. It also means that you will have issues when syncing back up to springsource/master, because there are now conflicting commits on your local master. You can solve this with git fetch springsource; git reset --hard springsource/master (assuming 'springsource' is the name of your remote for https://github.com/springsource/spring-framework-issues). But in any case it's nice to avoid this kind of thing.

Thanks for the contribution! We'll get this worked out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants