This repository was archived by the owner on Jan 21, 2022. It is now read-only.
GH-3: Workaround counter. prefix explicitly
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-attic#3 With Java 8 Spring Boot auto-configure `BufferCounterService` which has an inconsistency with the `DefaultCounterService`, where the last one checks for the `counter.` prefix, but `BufferCounterService` just for the `counter`. This is a problem because the `spring.application.name` is populated as `counter-sink`, therefore we don't have `counter.` in case of `BufferCounterService`. Having that the SCDF can't get access to our counter because it reads them as `spring.metrics.counter.*` * While Spring Boot is fixing consistency with the `counter.` prefix, we provide a workaround with an explicit setting `counter.` prefix in the `CounterSinkConfiguration`
Contributor
|
Looking good. Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
With Java 8 Spring Boot auto-configure
BufferCounterServicewhichhas an inconsistency with the
DefaultCounterService, where the lastone checks for the
counter.prefix, butBufferCounterServicejustfor the
counter.This is a problem because the
spring.application.nameis populated ascounter-sink, therefore we don't havecounter.in case ofBufferCounterService.Having that the SCDF can't get access to our counter because it reads them as
spring.metrics.counter.*counter.prefix, we providea workaround with an explicit setting
counter.prefix in theCounterSinkConfiguration