1.20 support

[Netherwhal]

Getting the following error:

[2023-06-24 08:12:36.314] [error] Canvas is empty !
[2023-06-24 08:12:36.321] [error] Error rendering terrain.

[spoutn1k]

Hey ! It looks like a quick fix. How are you running mcmap ? I have a 1.20.1 branch with the changes, let me know if you can compile and test it. If not, let me know your workflow and we'll figure something out.

[Netherwhal]

Thanks so much @spoutn1k looking much better :)

New blocks might still have to be added?

[2023-06-29 19:40:57.059] [mcmap_cli] [error] Color of block minecraft:cherry_planks not found
[2023-06-29 19:40:58.267] [mcmap_cli] [error] Color of block minecraft:cherry_log not found
[2023-06-29 19:40:58.268] [mcmap_cli] [error] Color of block minecraft:cherry_leaves not found
[2023-06-29 19:40:58.861] [mcmap_cli] [error] Color of block minecraft:bamboo_planks not found
[2023-06-29 19:44:53.609] [mcmap_cli] [error] Color of block minecraft:bamboo_door not found
[2023-06-29 19:44:53.941] [mcmap_cli] [error] Color of block minecraft:cherry_sapling not found
[2023-06-29 19:44:53.981] [mcmap_cli] [error] Color of block minecraft:pink_petals not found

But at least its not crashing:

• https://files.simplyvanilla.net/spawn/world/2023/world-2023-06-29.png
• https://files.simplyvanilla.net/spawn/world_nether/2023/world_nether-2023-06-29.png
• https://files.simplyvanilla.net/spawn/world_the_end/2023/world_the_end-2023-06-29.png

[spoutn1k]

Perfect ! Yes, block colors are a relatively simple addition compared to supporting whatever changes were made to the save format.

I compiled a list of the 70 missing textures using a debug world:

minecraft:acacia_hanging_sign
minecraft:acacia_wall_hanging_sign
minecraft:bamboo_block
minecraft:bamboo_button
minecraft:bamboo_door
minecraft:bamboo_fence_gate
minecraft:bamboo_fence
minecraft:bamboo_hanging_sign
minecraft:bamboo_mosaic
minecraft:bamboo_mosaic_slab
minecraft:bamboo_mosaic_stairs
minecraft:bamboo_planks
minecraft:bamboo_pressure_plate
minecraft:bamboo_sign
minecraft:bamboo_slab
minecraft:bamboo_stairs
minecraft:bamboo_trapdoor
minecraft:bamboo_wall_hanging_sign
minecraft:bamboo_wall_sign
minecraft:birch_hanging_sign
minecraft:birch_wall_hanging_sign
minecraft:calibrated_sculk_sensor
minecraft:cherry_button
minecraft:cherry_door
minecraft:cherry_fence_gate
minecraft:cherry_fence
minecraft:cherry_hanging_sign
minecraft:cherry_leaves
minecraft:cherry_log
minecraft:cherry_planks
minecraft:cherry_pressure_plate
minecraft:cherry_sapling
minecraft:cherry_sign
minecraft:cherry_slab
minecraft:cherry_stairs
minecraft:cherry_trapdoor
minecraft:cherry_wall_hanging_sign
minecraft:cherry_wall_sign
minecraft:cherry_wood
minecraft:chiseled_bookshelf
minecraft:crimson_hanging_sign
minecraft:crimson_wall_hanging_sign
minecraft:dark_oak_hanging_sign
minecraft:dark_oak_wall_hanging_sign
minecraft:decorated_pot
minecraft:jungle_hanging_sign
minecraft:jungle_wall_hanging_sign
minecraft:mangrove_hanging_sign
minecraft:mangrove_wall_hanging_sign
minecraft:oak_hanging_sign
minecraft:oak_wall_hanging_sign
minecraft:piglin_head
minecraft:piglin_wall_head
minecraft:pink_petals
minecraft:pitcher_crop
minecraft:pitcher_plant
minecraft:potted_cherry_sapling
minecraft:potted_torchflower
minecraft:sniffer_egg
minecraft:spruce_hanging_sign
minecraft:spruce_wall_hanging_sign
minecraft:stripped_bamboo_block
minecraft:stripped_cherry_log
minecraft:stripped_cherry_wood
minecraft:suspicious_gravel
minecraft:suspicious_sand
minecraft:torchflower_crop
minecraft:torchflower
minecraft:warped_hanging_sign
minecraft:warped_wall_hanging_sign

I really don't have time to go through all of them these days, so adding those is not a priority right now. If you want this to go faster, you can make the changes to src/colors.json and pull request them. There is a script to calculate the color average of a png in scripts/average.sh - you can get a png of all the blocks in the game by decompressing the version JAR in ~/.minecraft/versions.

[Netherwhal]

Thanks for the guidance, was able to create a PR @spoutn1k :)

[spoutn1k]

Thank you for putting in the effort ! Marking this as resolved.