Skip to content

Fixes selector to follow signature required by Apple documentation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes selector to follow signature required by Apple documentation #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd1d3d
Fixes selector to follow signature required by Apple documentation
valeriyvan Jan 27, 2019
ca8a202
Makes funcs private
valeriyvan Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions DemoProjects/NowPlayingView/NowPlayingView/ConnectionStatusIndicatorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ class ConnectionStatusIndicatorView : UIView {
self.setNeedsDisplay()
if state == .connecting {
if displayLink == nil {
let selector = #selector(setNeedsDisplay as () -> Void)
displayLink = CADisplayLink(target: self, selector:selector)
displayLink = CADisplayLink(target: self, selector: #selector(setNeedsDisplayProxy(_:)))
}
displayLink?.add(to: RunLoop.main, forMode: RunLoopMode.commonModes)
} else {
Expand Down Expand Up @@ -48,11 +47,11 @@ class ConnectionStatusIndicatorView : UIView {
context.fillPath()
}

fileprivate func timebasedValue() -> CGFloat {
private func timebasedValue() -> CGFloat {
return CGFloat(abs(sin(Date().timeIntervalSinceReferenceDate*4)))
}

fileprivate func fillColor() -> CGColor {
private func fillColor() -> CGColor {
switch state {
case .disconnected:
return UIColor.red.cgColor
Expand All @@ -62,4 +61,11 @@ class ConnectionStatusIndicatorView : UIView {
return UIColor.green.cgColor
}
}

// Needed because CADisplayLink(target:, selector:)
// waits for selector method having signature `(void)selector:(CADisplayLink *)sender`
// https://developer.apple.com/documentation/quartzcore/cadisplaylink/1621228-init
@objc private func setNeedsDisplayProxy(_ sender: CADisplayLink) {
setNeedsLayout()
}
}