This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Allow custom username prefix while creating ephemeral Splunk user #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelw
reviewed
Aug 9, 2019
michaelw
reviewed
Aug 9, 2019
path_creds_create.go
Outdated
| return nil, err | ||
| } | ||
| username := fmt.Sprintf("vault_%s_%s_%s_%d", name, req.DisplayName, userUUID, time.Now().UnixNano()) | ||
| username := fmt.Sprintf("%s_%s", role.UserPrefix, userUUID) |
There was a problem hiding this comment.
userUUID might not be unique, e.g., did you test same user requesting two emphemeral creds with overlapping lifetime?
There was a problem hiding this comment.
also, should we keep requestor name in there for tracking? (at least unless explicitly overridden)
There was a problem hiding this comment.
A new UUID is generated for userUUID for each new user. Check 3 lines above
There was a problem hiding this comment.
Added req.DisplayName to username
Accidentally, delete `go install` from `make build` target; while moving to go modules.
abhide
force-pushed
the
user-prefix
branch
3 times, most recently
from
3092b58 to
04e4da8
Compare
michaelw
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: TE-34