This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Add Get/Update methods for Properties API #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is new version required? Pick up fixes to specify custom ResponseDecoder
michaelw
reviewed
Aug 5, 2019
clients/splunk/properties.go
Outdated
|
|
||
| body := strings.NewReader(fmt.Sprintf("value=%s", value)) | ||
| resp, err := p.client.New().Post( | ||
| fmt.Sprintf("properties/%s/%s/%s", file, stanza, key)).Body(body).ResponseDecoder(stringResponseDecoder{}).Receive(nil, apiError) |
There was a problem hiding this comment.
do the interpolated values need some kind of escaping?
clients/splunk/properties.go
Outdated
| apiError := &APIError{} | ||
| output := &Entry{} | ||
| resp, err := p.client.New().Get( | ||
| fmt.Sprintf("properties/%s/%s/%s", file, stanza, key)).ResponseDecoder(stringResponseDecoder{}).Receive(output, apiError) |
| output := &Entry{} | ||
| resp, err := p.client.New().Get( | ||
| fmt.Sprintf("properties/%s/%s/%s", file, stanza, key)).ResponseDecoder(stringResponseDecoder{}).Receive(output, apiError) | ||
| if err != nil || !apiError.Empty() { |
There was a problem hiding this comment.
hmm, maybe we should make it such that we can check for exactly one condition.
There was a problem hiding this comment.
Will address these in a cleanup/refactor separate PR.
added 3 commits
August 5, 2019 22:01
CI would fail with make test TESTREPORT=test-results/go/results.xml sed -e 's;@@gobin@@;/go/bin;g' < vault.hcl.in > vault.hcl mkdir -p test-results/go/ go clean -testcache go clean -testcache: open /tmp/go/cache/testexpire.txt: no such file or directory make: *** [Makefile:29: test] Error 1
michaelw
reviewed
Aug 6, 2019
| @test -n "$$SPLUNK_ADDR" || { echo 'warning: SPLUNK_ADDR not set, creating new Splunk instances. This will be slow.'; } | ||
| mkdir -p $(dir $(TESTREPORT)) | ||
| gotestsum --junitfile $(TESTREPORT) -- -cover -v ./... | ||
| go clean -testcache || true |
There was a problem hiding this comment.
env GOCACHE=off gotestsum...
There was a problem hiding this comment.
mkdir -p ./
env GOCACHE=off gotestsum --junitfile test-results.xml --format standard-verbose -- -cover -v ./...
build cache is disabled by GOCACHE=off, but required as of Go 1.12
=== Errors
build cache is disabled by GOCACHE=off, but required as of Go 1.12
DONE 0 tests, 1 error in 0.015s
make: *** [test] Error 1```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.