Preserve thirdparty cookies #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashah-splunk
commented
Jun 8, 2022
ashah-splunk
commented
- added cookies into the request header if thirdparty cookies exisits
fantavlik
approved these changes
Jun 13, 2022
Merged
Merged
|
Were the tests updated to ensure there won't be any regressions? |
|
@bendikro yes tests were updated in PR #449 as part of the fix for issue #438. As we cannot have a setup with a middleware on the CI test execution we do not have tests for the exact scenario instead we have test cases where some cookie exists but not the Splunk Auth Cookie and authentication is carried out using username and password. Here Username/Password can be substituted by either Session key or bearer token. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.