Skip to content

Release workflow refactor #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 13, 2022
Merged

Release workflow refactor #446

merged 7 commits into from
Apr 13, 2022

Conversation

ashah-splunk
Copy link
Contributor

  • Updated authentication error message as it was a bit confusing
  • Refactored release workflow to trigger only when a new release is created instead of every push on the Master branch

@ashah-splunk ashah-splunk requested a review from fantavlik April 12, 2022 15:23
fantavlik
fantavlik approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally it's probably best to split these into two different PRs but I think it's fine to merge. Thanks!

@ashah-splunk ashah-splunk merged commit e162cc0 into develop Apr 13, 2022
@ashah-splunk ashah-splunk deleted the release-workflow-refactor branch May 2, 2022 06:58
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantavlik fantavlik fantavlik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashah-splunk @fantavlik