Skip to content

properly add parameters to request based on the method of the request #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021
Merged

properly add parameters to request based on the method of the request #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7a631a
properly add parameters to request based on the method of the request
billmurrin Jul 24, 2019
19d59c6
reduced number of api calls
billmurrin Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions splunklib/binding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ def post(self, path_segment, owner=None, app=None, sharing=None, headers=None, *

@_authentication
@_log_duration
def request(self, path_segment, method="GET", headers=None, body="",
def request(self, path_segment, method="GET", headers=None, body={},
owner=None, app=None, sharing=None):
"""Issues an arbitrary HTTP request to the REST path segment.

Expand Down Expand Up @@ -814,13 +814,28 @@ def request(self, path_segment, method="GET", headers=None, body="",
path = self.authority \
+ self._abspath(path_segment, owner=owner,
app=app, sharing=sharing)

all_headers = headers + self.additional_headers + self._auth_headers
logging.debug("%s request to %s (headers: %s, body: %s)",
method, path, str(all_headers), repr(body))
response = self.http.request(path,
{'method': method,
'headers': all_headers,
'body': body})

if body:
body = _encode(**body)

if method == "GET":
path = path + UrlEncoded('?' + body, skip_encode=True)
message = {'method': method,
'headers': all_headers}
else:
message = {'method': method,
'headers': all_headers,
'body': body}
else:
message = {'method': method,
'headers': all_headers}

response = self.http.request(path, message)

return response

def login(self):
Expand Down