WIP :- SSL certificate validation #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashah-splunk
commented
Jan 19, 2023
ashah-splunk
commented
- method to set SSL certificate
- README updated on how to set SSL certificate for verification
- Test case setup updated with commented code on how to set SSL certificate
- method to add SSL certificate - README updated on how to set SSL certificate - Test case updated with commented code using SSL certificate
jrobins04
reviewed
Apr 24, 2023
| ###SSL Certificate Verification | ||
| SSL Certificate validation is turned ON by default in Splunk Java SDK. Set SSL Certificate as shown below. | ||
| ```java | ||
| HttpService.setSSLCert(<byte[] sslCert>); |
There was a problem hiding this comment.
This still needs the data input app to provide the cert. How do the data input app figure out which cert to provide here when communicating with the Splunk Enterprise/Cloud ?
l00py
reviewed
Sep 13, 2023
| cd splunk | ||
| mvn javadoc:javadoc | ||
|
|
||
| ###SSL Certificate Verification |
l00py
reviewed
Sep 13, 2023
| // Bypass the certification validation here. | ||
| public static void preClassLoadActions() throws IOException { | ||
| // To Bypass the certification validation. | ||
| HttpService.setValidateCertificates(false); |
There was a problem hiding this comment.
Could we have separate tests:
- For simulating the failure of an SSL cert validation
- and/or when setting to
true, the ability to connect to the HTTPS resource with a valid SSL certificate?
| // For now this check is set as null. | ||
| // TODO: Implementation logic for validating client certificate. | ||
| } else { | ||
| if(sslCert == null){ |
There was a problem hiding this comment.
I would add spaces between if and ( also between ) and {.
| if(sslCert == null){ | ||
| // On initialising before ssCert is set, TM and KM set to null | ||
| context.init(null, null, null); | ||
| }else{ |
There was a problem hiding this comment.
I would add spaces between } and else and {
| tmf.init(ks); | ||
| context.init(null, tmf.getTrustManagers(), null); | ||
| } | ||
| } else{ |
There was a problem hiding this comment.
I would add a space between else and {
| }else{ | ||
| InputStream is = new ByteArrayInputStream(sslCert); | ||
| CertificateFactory cf = CertificateFactory.getInstance("X.509"); | ||
| X509Certificate cert = (X509Certificate)cf.generateCertificate(is); |
There was a problem hiding this comment.
Do we need this cast to X509Certificate? It looks like the method ks.setCertificateEntry("cert", cert); supports a Certificate in the signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.