-
Notifications
You must be signed in to change notification settings - Fork 125
fix isAppAlreadyInstalledo error handling #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrykw-splunk
wants to merge
7
commits into
develop
Choose a base branch
from
feature/fix-error-handling-in-afwscheduler
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix isAppAlreadyInstalledo error handling #1608
patrykw-splunk
wants to merge
7
commits into
develop
from
feature/fix-error-handling-in-afwscheduler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiakoziol
approved these changes
Nov 5, 2025
rlieberman-splunk
approved these changes
Nov 7, 2025
Collaborator
Pull Request Test Coverage Report for Build 19497371957Details
💛 - Coveralls |
kubabuczak
reviewed
Nov 14, 2025
| stdOut, stdErr, err := localCtx.podExecClient.RunPodExecCommand(rctx, streamOptions, []string{"/bin/sh"}) | ||
|
|
||
| // Handle FIPS messages in stderr - these are informational, not errors | ||
| if stdErr != "" && strings.Contains(stdErr, "FIPS provider enabled") { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to ignore stdErr at all - error code should indicate an error. Did we run into problems that are indicated only in stdErr and not in error code?
977edc7 to
6546a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix FIPS Error Handling:
Modified
isAppAlreadyInstalled()andinstallApp()functions to properly handle FIPS provider informational messages in stderr by treating them as non-error conditions rather than installation failures.Also added fanout CR status synchronization (
installPhaseManager()) to ensure that when app installation fails after max retries on any replica, the main PhaseInfo is properly updated to reflect the overall deployment failure state.Key Changes
FIPS error handling
isAppAlreadyInstalled()function to detect and ignore FIPS provider informational messages in stderr instead of treating them as errorsinstallApp()function to handle FIPS messages during app installation, preventing false installation failuresFanout CR Status Management
Testing and Verification
Fixed
TestPremiumAppScopedPlaybook:Added comprehensive
TestIsAppAlreadyInstalledfunction:Related Issues
N/A
PR Checklist