CSPL-4207: Move test yamls into fixtures #1607
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 5, 2025 12:42
- Added bytes and encoding/json imports - Modified loadFixture() to use json.Compact() to minify fixture files - This allows pretty-printed fixture files to match compact json.Marshal output - Fixes TestApplySmartstoreConfigMap and other tests using configTester2
kasiakoziol
approved these changes
Nov 6, 2025
Collaborator
|
Please update the description of the PR. |
rlieberman-splunk
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors test suite to use JSON fixture files instead of inline JSON strings.
Key Changes
loadFixture()helper inutil.gothat loads and compacts JSON from fixture filesTesting and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist