Added new config option with readme documentation #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @MattMakes, Also, it would add more clarity to this change, if you add test case supporting this use-case. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this to allow us to configure an http/https agent for keep alive configurations. We've seen a large number of sockets being opened up by this library when used by our projects and believe it's due to not having configs available to update the request node module (which is now deprecated, btw, but that'll have to be another PR..).
The example provides an usage example - but the simplicity of it would allow for using something more complex like this too: https://github.com/node-modules/agentkeepalive
Please let me know if you have questions or concerns.