-
Notifications
You must be signed in to change notification settings - Fork 121
test: (ADDON-81912) add docker and podman e2e test strategy #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
test: (ADDON-81912) add docker and podman e2e test strategy #2823
Conversation
* ci: add e2e tests for docker and podman * chore: fix test failures in docker e2e * chore: make changes to fix issues in execution * chore: test * chore: test * chore: test * chore: update SC4S_IMAGE settings * chore: use sudo * chore: test without setting ENV * chore: test named cache * chore: test * chore: also update ci lite * chore: test * chore: Update artifacts name and use sed command to update SC4S image * chore: test * chore: debug things * chore: test * chore: test * chore: test * chore: Update ci enterprise * chore: test * chore: test * chore: test
| - test-container | ||
| - test-ipv4-name-cache | ||
| - test-ipv6-name-cache | ||
| - test-name-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have some tests failing now:
[gw0] [ 20%] FAILED tests/test_name_cache.py::test_name_cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as mentioned in the PR note, there is 1 test failing for each stages. I am checking on it, but this is to review the rest of the changes of the Github Actions.
ajasnosz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have other comments that weren't already mentioned here, if they will be addressed and the test would pass I think it's ok.
For the future PRs we also use tags from semantic release like fix/ test/ instead of addon number in the branch name 😃
Jira: https://splunk.atlassian.net/browse/ADDON-81912
NOTE: 1 tests case is failing for "test-container" and "test-name-cache". I am working on fixing thise