Support array-of-string in formatted HEC additional fields #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct> to support multi-value fields/arrays. Fixed splunk#444.
javabrett
had a problem deploying
to
workflow-approval
GitHub Actions
Error
javabrett
had a problem deploying
to
workflow-approval
GitHub Actions
Error
Kawron
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
Thank you @javabrett for your contirbution. The PR looks good to me
javabrett
had a problem deploying
to
workflow-approval
GitHub Actions
Error
javabrett
had a problem deploying
to
workflow-approval
GitHub Actions
Error
pszkamruk-splunk
approved these changes
Aug 19, 2025
javabrett
had a problem deploying
to
workflow-approval
GitHub Actions
Error
Kawron
requested changes
Aug 21, 2025
There was a problem hiding this comment.
@javabrett Could you pease rebase your PR. I've commited new changes, that has to be merged to your PR in order to run the testing pipeline
|
I'm closing this PR due to inactivity. A new one will the latest changes will be created instead: #449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sink cannot handle JSON
fieldskeys/values where the value is an array of string e.g.["value1", "value2"], when running withsplunk.hec.json.event.formatted=true. HEC supports these records but the sink doesn't. This PR fixes that. See issue #444 for details.Main change is project-wide change of fields map definition from
Map<String, String>toMap<String, Object>. Jackson can then parse the array of string.Added unit test.
Fixes #444 .