Validate Splunk configuration before creating task #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deep-splunk
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
deep-splunk
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
hvaghani221
previously approved these changes
Dec 12, 2022
.vscode/settings.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove unwanted files
| import java.util.function.Function; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import org.apache.avro.Protocol; |
There was a problem hiding this comment.
Are these imports required? If not, please remove them.
| private Map<String, String> taskConfig; | ||
| private Map<String, ConfigValue> values; | ||
| private List<ConfigValue> validations; | ||
| private AbstractClientWrapper hecAb = new HecClientWrapper(); |
There was a problem hiding this comment.
nit: Should have some meaningful name
| } | ||
|
|
||
|
|
||
| private void validateHealthCheckForSplunkIndexes(final Map<String, String> configs) throws ConfigException { |
There was a problem hiding this comment.
Is it validating splunk health?
| private void healthCheckForSplunkHEC(SplunkSinkConnectorConfig connectorConfig, String index) throws ConfigException { | ||
| Header[] headers; | ||
| headers = new Header[1]; | ||
| headers[0] = new BasicHeader("Authorization", String.format("Splunk %s", connectorConfig.splunkToken)); |
There was a problem hiding this comment.
Can you define headers as an inline array?
| final HttpPost httpPost = new HttpPost(url); | ||
| httpPost.setHeaders(headers); | ||
| EventBatch batch = new JsonEventBatch(); | ||
| Event event = new JsonEvent("a:a", null); |
There was a problem hiding this comment.
What does "a:a" represents?
| ((SplunkSinkConnector) connector).setHecInstance(clientInstance); | ||
| Assertions.assertDoesNotThrow(()->connector.validate(configs)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you also add tests for an invalid host, and invalid SSL configuration(i.e. HTTP request on HTTPS server and vice-versa)?
deep-splunk
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
deep-splunk
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
hvaghani221
previously approved these changes
Dec 13, 2022
deep-splunk
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
hvaghani221
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.