Skip to content

handled null custom header values #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

handled null custom header values #326

merged 3 commits into from
May 13, 2022

Conversation

@kashyap-splunk
Copy link
Contributor

@kashyap-splunk kashyap-splunk commented Apr 28, 2022 •
edited
Loading

  • This handles a rare situation where a custom header is set but its value is not set in the Kafka records.
  • Also, added Kafka 3.1.0 in functional tests pipeline

@github-actions
Copy link

github-actions bot commented Apr 28, 2022 •
edited
Loading

Unit Test Results

  23 files    23 suites   38s ⏱️
143 tests 143 ✔️ 0 💤 0 ❌

Results for commit f5fb854.

♻️ This comment has been updated with latest results.

@kashyap-splunk kashyap-splunk requested review from a user and hvaghani221 April 28, 2022 15:08
@kashyap-splunk kashyap-splunk marked this pull request as ready for review April 28, 2022 15:08
hvaghani221
hvaghani221 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kashyap-splunk kashyap-splunk merged commit 374ef35 into develop May 13, 2022
@kashyap-splunk kashyap-splunk deleted the null-custom-header branch May 13, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hvaghani221 hvaghani221 hvaghani221 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kashyap-splunk @hvaghani221