Skip to content

Header Fix, Add hostname metadata, code quality fix #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2019
Merged

Header Fix, Add hostname metadata, code quality fix #181

merged 3 commits into from
May 1, 2019

Conversation

@dtregonning
Copy link
Contributor

@dtregonning dtregonning commented May 1, 2019

  • Improved Header behavior in raw events
  • Added HOSTNAME for task and added to meta-data
  • QOL improvement to generic implementation in handleRecordsWithHeader()

chaitanyaphalak
chaitanyaphalak approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@chaitanyaphalak chaitanyaphalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtregonning dtregonning merged commit d43e5ed into develop May 1, 2019
@dtregonning dtregonning deleted the INGEST-6610-fixes branch May 1, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chaitanyaphalak chaitanyaphalak chaitanyaphalak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtregonning @chaitanyaphalak