Updated naming throughout project per issue #117 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtregonning
reviewed
Mar 9, 2018
Contributor
dtregonning
left a comment
dtregonning
left a comment
There was a problem hiding this comment.
Thanks @gp510
Has everything been built, deployed and tested?
Contributor
|
Would like to understand who requested these changes and why ? |
Contributor
|
We don't need all this renaming. Glen did a little to much. We need to change some docs and the bainry names not all the internals. |
dtregonning
suggested changes
Mar 9, 2018
Contributor
dtregonning
left a comment
dtregonning
left a comment
There was a problem hiding this comment.
Dial back the internal changes
dtregonning
reviewed
Mar 13, 2018
| githash=@8190911 | ||
| gitbranch=develop | ||
| gitversion=dev | ||
| githash=@ae68d5b |
Contributor
There was a problem hiding this comment.
remove all references to this branch. don't commit this file
dtregonning
reviewed
Mar 13, 2018
| <groupId>com.github.splunk.kafka.connect</groupId> | ||
| <artifactId>kafka-connect-splunk</artifactId> | ||
| <version>dev-SNAPSHOT</version> | ||
| <version>v1.0.0-LAR</version> |
dtregonning
reviewed
Mar 13, 2018
| <artifactId>kafka-connect-splunk</artifactId> | ||
| <name>kafka-connect-splunk</name> | ||
| <version>dev-SNAPSHOT</version> | ||
| <version>v1.0.0-LAR</version> |
Contributor
|
You've only modified the build script you need to modify the project so that maven will build the new JAR file with the correct name. @gp510 |
Contributor
|
LGTM |
dtregonning
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.