Skip to content

Adding callout to both --volume and --mount #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Adding callout to both --volume and --mount #382

merged 1 commit into from
Jun 11, 2020

Conversation

nwang92
Copy link
Contributor

@nwang92 nwang92 commented Jun 11, 2020

Fixes #377

There actually weren't many spots where -v/--volume were used, but I added both options for usability. Thanks for catching this @edumserrano!

@nwang92 nwang92 requested review from alishamayor and bb03 as code owners June 11, 2020 03:58
@edumserrano
Copy link

edumserrano commented Jun 11, 2020 •
edited
Loading

Nicely done @nwang92. I believe this will prevent others from facing #324

@nwang92 nwang92 merged commit 692fb52 into develop Jun 11, 2020
@nwang92 nwang92 deleted the docs/volume-mounting branch June 11, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alishamayor alishamayor Awaiting requested review from alishamayor

@bb03 bb03 Awaiting requested review from bb03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible documentation update
2 participants
@nwang92 @edumserrano