Skip to content

Bloomfilter clear fix #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Bloomfilter clear fix #537

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdbba26
Merge pull request #513 from splitio/development
sanzmauro Mar 25, 2024
e4f7f17
Merge pull request #535 from splitio/development
chillaq May 3, 2024
a4d717d
cleared bloom filter by deleting and recreating the object
Dec 16, 2024
eb7509b
setting object to nil instead
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/splitclient-rb/cache/filter/bloom_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,35 @@ module Filter
class BloomFilter
def initialize(capacity, false_positive_probability = 0.001)
@capacity = capacity.round
m = best_m(capacity, false_positive_probability)
@ba = BitArray.new(m.round)
@m = best_m(capacity, false_positive_probability)
reset_filter
@k = best_k(capacity)
end

def add(string)
return false if contains?(string)

positions = hashes(string)

positions.each { |position| @ba[position] = 1 }

true
end

def contains?(string)
!hashes(string).any? { |ea| @ba[ea] == 0 }
end

def clear
@ba.size.times { |i| @ba[i] = 0 }
@ba = nil
reset_filter
end

private

def reset_filter
@ba = BitArray.new(@m.round)
end

# m is the required number of bits in the array
def best_m(capacity, false_positive_probability)
-(capacity * Math.log(false_positive_probability)) / (Math.log(2) ** 2)
Expand Down
Loading