Skip to content

[TS] Update Client and Manager interfaces in JS SDK to extend EventEmitter #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: [TS] Type definitions SplitIO namespace
wants to merge 1 commit into from
Closed

[TS] Update Client and Manager interfaces in JS SDK to extend EventEmitter #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions src/splitio.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,28 +20,6 @@ interface IEventEmitter {
removeAllListeners(event?: string): this
emit(event: string, ...args: any[]): boolean
}
/**
* NodeJS.EventEmitter interface
* @see {@link https://nodejs.org/api/events.html}
*/
interface EventEmitter extends IEventEmitter {
addListener(event: string | symbol, listener: (...args: any[]) => void): this;
on(event: string | symbol, listener: (...args: any[]) => void): this;
once(event: string | symbol, listener: (...args: any[]) => void): this;
removeListener(event: string | symbol, listener: (...args: any[]) => void): this;
off(event: string | symbol, listener: (...args: any[]) => void): this;
removeAllListeners(event?: string | symbol): this;
setMaxListeners(n: number): this;
getMaxListeners(): number;
listeners(event: string | symbol): Function[];
rawListeners(event: string | symbol): Function[];
emit(event: string | symbol, ...args: any[]): boolean;
listenerCount(type: string | symbol): number;
// Added in Node 6...
prependListener(event: string | symbol, listener: (...args: any[]) => void): this;
prependOnceListener(event: string | symbol, listener: (...args: any[]) => void): this;
eventNames(): Array<string | symbol>;
}
/**
* @typedef {Object} EventConsts
* @property {string} SDK_READY The ready event.
Expand Down Expand Up @@ -295,9 +273,9 @@ interface ISharedSettings {
/**
* Common API for entities that expose status handlers.
* @interface IStatusInterface
* @extends EventEmitter
* @extends IEventEmitter
*/
interface IStatusInterface extends EventEmitter {
interface IStatusInterface extends IEventEmitter {
/**
* Constant object containing the SDK events for you to use.
* @property {EventConsts} Event
Expand Down Expand Up @@ -344,6 +322,28 @@ interface IBasicClient extends IStatusInterface {
* @see {@link https://www.npmjs.com/package/@splitsoftware/splitio}
*/
declare namespace SplitIO {
/**
* NodeJS.EventEmitter interface
* @see {@link https://nodejs.org/api/events.html}
*/
interface EventEmitter extends IEventEmitter {
addListener(event: string, listener: (...args: any[]) => void): this;
on(event: string, listener: (...args: any[]) => void): this;
once(event: string, listener: (...args: any[]) => void): this;
removeListener(event: string, listener: (...args: any[]) => void): this;
off(event: string, listener: (...args: any[]) => void): this;
removeAllListeners(event?: string): this;
setMaxListeners(n: number): this;
getMaxListeners(): number;
listeners(event: string): Function[];
rawListeners(event: string): Function[];
emit(event: string, ...args: any[]): boolean;
listenerCount(type: string): number;
// Added in Node 6...
prependListener(event: string, listener: (...args: any[]) => void): this;
prependOnceListener(event: string, listener: (...args: any[]) => void): this;
eventNames(): Array<string | symbol>;
}
/**
* Split treatment value, returned by getTreatment.
* @typedef {string} Treatment
Expand Down