[FME-11056] Added fallback treatment and calculator #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
gthea
approved these changes
Nov 14, 2025
| type FallbackTreatment struct { | ||
| Treatment string | ||
| Config string | ||
| Label *string |
There was a problem hiding this comment.
If an instance of FallbackTreatment can be created by the customer, make sure they can't set the Label. Label is for our internal use only.
Contributor
Author
There was a problem hiding this comment.
When I update go-client with these changes, I'll check this. But for now, this struct is internal.
Comment on lines
12
to
15
| GlobalFallbackTreatment: &FallbackTreatment{ | ||
| Treatment: "global_treatment", | ||
| Config: "global_config", | ||
| }, |
There was a problem hiding this comment.
If possible, we should be able to set fallbacks without Config with just a String representing the treatment. For example:
GlobalFallbackTreatment: "global_treatment",equals
GlobalFallbackTreatment: &FallbackTreatment{
Treatment: "global_treatment",
Config: nil,
},
Contributor
Author
There was a problem hiding this comment.
Updated test cases to include 'nil' in the config.
MartinCardozo-SDK
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GO SPLIT COMMONS
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes