-
Notifications
You must be signed in to change notification settings - Fork 282
ref(templates/go): use spinframework import path #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right after opening this, I'm thinking we may want to cut a release of the SDK in it's new home first. |
I think it would be nice to pin to a known release. I wasn't sure what the release strategy in the upstream go SDK is, what with the push to support wasip2. |
79aa222
to
d092f31
Compare
@adamreese I rebased this in the hope of fixing the unrelated JS CI failure. If it now passes, do you want me to approve and merge, or are you still pondering pinning a known release? |
I didn't feel fully confident making the decision to bump the existing repo. A big reason being that there's some POC's out there that are using the wasip2 branch. The code in the branch is under the |
Tracking issue for the SDK version: spinframework/spin-go-sdk#22 |
@itowlson I'm going to tag the SDK but a few changes need to get in first that are pending review. I'll update this PR when the SDK is tagged |
Signed-off-by: Adam Reese <[email protected]>
d092f31
to
6c4b591
Compare
Upstream SDK has been tagged. This is good to go |
@adamreese CI for new PRs (i.e. using the updated templates) is failing with
|
There's no tagged releases for the new Go SDK. This pins the SDK in the templates to a git sha.