Skip to content

ref(templates/go): use spinframework import path #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

adamreese
Copy link
Contributor

There's no tagged releases for the new Go SDK. This pins the SDK in the templates to a git sha.

@adamreese
Copy link
Contributor Author

Right after opening this, I'm thinking we may want to cut a release of the SDK in it's new home first.

@vdice
Copy link
Contributor

vdice commented Apr 17, 2025

Right after opening this, I'm thinking we may want to cut a release of the SDK in it's new home first.

I think it would be nice to pin to a known release. I wasn't sure what the release strategy in the upstream go SDK is, what with the push to support wasip2.

@itowlson itowlson force-pushed the ref/go-template-import branch from 79aa222 to d092f31 Compare July 1, 2025 22:28
@itowlson
Copy link
Collaborator

itowlson commented Jul 1, 2025

@adamreese I rebased this in the hope of fixing the unrelated JS CI failure. If it now passes, do you want me to approve and merge, or are you still pondering pinning a known release?

@adamreese
Copy link
Contributor Author

I didn't feel fully confident making the decision to bump the existing repo. A big reason being that there's some POC's out there that are using the wasip2 branch. The code in the branch is under the /v2 path. I'll raise the question again to see if anyone has feelings now on it. Otherwise, I'll make the call this week.

@adamreese
Copy link
Contributor Author

Tracking issue for the SDK version: spinframework/spin-go-sdk#22

@adamreese
Copy link
Contributor Author

@itowlson I'm going to tag the SDK but a few changes need to get in first that are pending review. I'll update this PR when the SDK is tagged

@adamreese adamreese force-pushed the ref/go-template-import branch from d092f31 to 6c4b591 Compare July 10, 2025 17:52
@adamreese
Copy link
Contributor Author

Upstream SDK has been tagged. This is good to go

@itowlson itowlson merged commit aa46a55 into spinframework:main Jul 14, 2025
17 checks passed
@itowlson
Copy link
Collaborator

@adamreese CI for new PRs (i.e. using the updated templates) is failing with

go: errors parsing go.mod:
go.mod:5: require github.com/spinframework/spin-go-sdk: version "v2.2.1" invalid: should be v0 or v1, not v2

@adamreese adamreese deleted the ref/go-template-import branch July 14, 2025 14:16
@adamreese
Copy link
Contributor Author

@itowlson Go mods strikes again. I foobared it #3198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants