Skip to content

Conversation

@pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Nov 20, 2021

Toward #7405

  • Port doctools.js
    • (missing piece right now is make the search highlighting work)
    • Update tests
  • Port searchtools.js
    • Update tests
  • Documentation callouts
  • Changelog entry

Live-ish list of changes:

  • Make all JS function utilities "private", by prefixing an underscore.
  • When highlighting content, only highlight content within [role="main"],
    since that is where the search is done.
  • Only handle toggle buttons for domainindex.js, in [role="main"].
  • Drop unused JS functions: addContextElements, getCurrentURL, makeURL.

@AA-Turner
Copy link
Member

@pradyunsg can this be closed since #10028 was merged?

A

@pradyunsg
Copy link
Contributor Author

Yes!

@pradyunsg pradyunsg closed this Feb 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants