- 
                Notifications
    
You must be signed in to change notification settings  - Fork 41
 
          Fix missing aggregation separators, add patches Django app
          #6115
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
patches Django app
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-  Verify that all separators are cleared in 
v7.9.6.2in aDataObjFormattersapp resource - Pull this PR and run the migration
 - Verify that all empty separators have been restored to default
 
Looks good! All empty separators are restored.
This branch also makes aggregators appear in the visual editor menu that weren't previously hidden without enabling 'Show All Tables' (mostly Attachment tables). I think all of these tables have default aggregators, so it's probably not a problem unless they really need to be hidden.
Triggered by a0c1fdf on branch refs/heads/issue-5154-patch
Triggered by 746f54c on branch refs/heads/issue-5154-patch
| 
           This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-10-2-release-announcement/2455/1  | 
    




Warning
This PR affects database migrations. See migration testing instructions.
Fixes #5154, but retroactively, since this has already led to a lot of issues since the bug was introduced, and now its been insidiously spreading since (reported by numerous users, just solved another case today so I figured I should solve all of them at once).
This also creates a
patchesDjango app that we can add to in the future when needing to do something like this.It runs this on all databases:
You cannot set the separator to nothing (
""), so we can be very confident this solves cases where the default was lost and does not break cases where it is not desired.Checklist
self-explanatory (or properly documented)
Testing instructions
Before using this branch, switch to
v7.9.6.2and edit the separator for any table aggregation.Once you do, all default separators for table aggregations will be set to
""rather than"; ". This leads to very undesirable results where all Preparations or Collectors are aggregated together into a single string 😵Verify that all separators are cleared in
v7.9.6.2in aDataObjFormattersapp resourcePull this PR and run the migration
Verify that all empty separators have been restored to default